NIAD-3304: Adaptor not preserving legacy read codes on export #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…export * Add initial unit test for mapping allergy codable concepts.
…e concept mapping
* Refactor `findOriginalText`method to accept functional parameter so that different ways of retrieving the description display extension can be used.
* Refactor `findOriginalText`method to accept functional parameter so that different ways of retrieving the description display extension can be used.
…sion is not defined by the url as a description extension.
…ept has only non-snomed codes.
…ept has only non-snomed codes.
Collaborator
Author
|
Pitest surviving mutant is due to a bug in the original code which cannot be tested as the code is never hit. This bug will be addressed in a future pull request |
|
|
Bhavesh-Patel
approved these changes
Mar 12, 2025
MartinWheelerMT
deleted the
niad-3304-adaptor-not-preserving-legacy-read-codes-on-export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
CodeableConceptfor blood pressures.CodeableConceptCdMapperfor readability and allow testing around existing bug when retrieving the original text value from the display extension.Why
This method was untested and changes are required when handling non-SNOMEDCT codes.
Type of change
Please delete options that are not relevant.
Checklist: